[#1354] Revert experimental GroovyTempate.compile code to fix template issue #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o fix template files saving to projects root
tazmaniax
reviewed
Dec 27, 2021
tazmaniax
added a commit
to tazmaniax/play1
that referenced
this pull request
Jan 26, 2022
Applies changes made in playframework#1368 to revert unnecessary and incorrect changes to GroovyTemplate introduced in playframework#1338
|
Just because it's taking a while to get this released I've applied this change to my JDK 17 compatible Play1 pull request, which also now replaces Log4j with reload4j. |
xael-fry
approved these changes
Jan 28, 2022
|
🎉 Thank you! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Helpful things
Issue Discussion: #1354
Breaking commit: 8e2e363
Fixes
Fixes #1354
Purpose
This pull request:
Background Context
This was discussed in the linked thread. Reverting back to the old behavior seems reasonable as well as we know it was working properly and was changed to get rid of reflection, not to fix a bug.
We may want to add an improvement ticket to look back at this area and re-write the reflection code because reflection is usually a bad idea.
References
#1354
8e2e363